IBX-8350: Text line fields which is not marked as required, but has a minimum length constraint set, is basically treated as required #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… minimum length constraint set, is basically treated as required
2 tasks
|
bogusez
approved these changes
Jul 2, 2024
dew326
approved these changes
Jul 2, 2024
dew326
deleted the
IBX-8350_fix_js_valiation_of_minimal_length_constrain_for_text_line_fields
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When input is checked for length constrains in JS, it is not taken into account whatever the field is empty or not. ( As long as the field is not required, it is okay that the value is empty even if it has a constrain on minimum characters )
This PR is a re-make of #2120 which closed due to a comma in branch name which caused problems for CI
PR 2120 is already reviewed and approved by QA
Checklist:
$ composer fix-cs)