Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-28605: Change link to edit CT draft on search result #232

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Dec 19, 2017

Question Answer
Tickets https://jira.ez.no/browse/EZP-28605
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Change link to edit CT draft on search result. Also may affect restoring Archived versions in Versions tab in CT.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lserwatka
Copy link
Member

@mikadamczyk rebase is needed here

@mikadamczyk mikadamczyk force-pushed the ezp-28605-change-link-to-edit-CT-draft-on-search-result branch 2 times, most recently from 9bf5209 to 7502f93 Compare December 19, 2017 13:39
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA tests ok.

@m-tyrala m-tyrala removed their assignment Dec 19, 2017
@webhdx
Copy link
Contributor

webhdx commented Dec 19, 2017

This is potentially destructive - did you check how does it work on Content View page where SIL and Edit widgets are using 2 content edit forms?

Should be ok.

@lserwatka
Copy link
Member

It should be similar as in the Sub-Items List

@mikadamczyk mikadamczyk force-pushed the ezp-28605-change-link-to-edit-CT-draft-on-search-result branch from 7502f93 to 1780308 Compare December 19, 2017 14:29
@mikadamczyk
Copy link
Contributor Author

Rebase done

@lserwatka lserwatka merged commit 2918664 into ezsystems:master Dec 19, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

4 participants