Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-28636: Universal Discovery Widget should have configurable root location ID #255

Merged
merged 2 commits into from
Dec 21, 2017
Merged

EZP-28636: Universal Discovery Widget should have configurable root location ID #255

merged 2 commits into from
Dec 21, 2017

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Dec 21, 2017 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-28489
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@webhdx webhdx self-assigned this Dec 21, 2017
dew326
dew326 requested changes Dec 21, 2017
View reviewed changes
Copy link
Member

@dew326 dew326 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should componentize AlloyEditor

@webhdx webhdx force-pushed the udw_default_location branch from 8678463 to e8b8de6 Compare December 21, 2017 11:03
@m-tyrala m-tyrala self-assigned this Dec 21, 2017
@webhdx webhdx force-pushed the udw_default_location branch from e8b8de6 to 1bd7075 Compare December 21, 2017 15:24
m-tyrala
m-tyrala approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@m-tyrala m-tyrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA tests ok.

@m-tyrala m-tyrala removed their assignment Dec 21, 2017
@lserwatka lserwatka merged commit e3597cf into ezsystems:master Dec 21, 2017
@webhdx webhdx deleted the udw_default_location branch March 7, 2018 13:53
mateuszdebinski pushed a commit that referenced this pull request Oct 25, 2022
@GrabowskiM
IBX-1156: Wrong size all inputs/dropdowns, etc. in table (#255)
b31aeee
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@m-tyrala m-tyrala m-tyrala approved these changes

@dew326 dew326 dew326 approved these changes

@sunpietro sunpietro sunpietro approved these changes

@lserwatka lserwatka Awaiting requested review from lserwatka

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@micszo micszo Awaiting requested review from micszo

Assignees

@webhdx webhdx

Labels
Improvement QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@webhdx @sunpietro @dew326 @m-tyrala @lserwatka