Fix menu item voter conflicting with other voters #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voters should return `null` if they can't decide if menu item is active or not, rather than `false`, because returning `false` prevents other voters from functioning properly. This messes up the voter implemented in Tags Bundle for example.
mikadamczyk
approved these changes
Dec 21, 2017
mateuszdebinski
pushed a commit
that referenced
this pull request
Oct 25, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voters should return
nullif they can't decide if menu item is active or not, rather thanfalse, because returningfalseprevents other voters from functioning properly.This messes up the voter implemented in Tags Bundle for example.
Checklist:
$ composer fix-cs)