EZP-28722: Add unit tests to Compiler Passes #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
approved these changes
Jan 15, 2018
|
|
||
| class ComponentPass implements CompilerPassInterface | ||
| { | ||
| const TAG_NAME = 'ezplatform.admin_ui.component'; | ||
| public const TAG_NAME = 'ezplatform.admin_ui.component'; |
There was a problem hiding this comment.
should this be unified across all new PRs? it is not in PSR afair?
There was a problem hiding this comment.
I wouldn't go with that change in this PR. I see PHPStorm is proposing this change but this will introduce too many inconsistencies in the codebase.
webhdx
suggested changes
Jan 22, 2018
| @@ -16,9 +16,12 @@ | |||
| */ | |||
| class TabPass implements CompilerPassInterface | |||
| { | |||
| const TAG_TAB = 'ezplatform.tab'; | |||
| public const TAG_TAB = 'ezplatform.tab'; | |||
| use Symfony\Component\DependencyInjection\Reference; | ||
|
|
||
| /** | ||
| * Supplies config Providers to the Aggregator. | ||
| */ | ||
| class UiConfigProviderPass implements CompilerPassInterface | ||
| { | ||
| public function process(ContainerBuilder $container) | ||
| public const TAG_CONFIG_PROVIDER = 'ezplatform.admin_ui.config_provider'; |
mikadamczyk
force-pushed
the
ezp-28722-add-unit-tests-to-compiler-passes-
branch
from
4a3a4a0 to
eab56e7
Compare
webhdx
approved these changes
Jan 22, 2018
mateuszdebinski
pushed a commit
that referenced
this pull request
Oct 25, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests to Compiler Passes
Checklist:
$ composer fix-cs)