Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZEE-3214: Dropped default value from Workflow Markings message column #149

Merged

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jul 2, 2020

JIRA issue: EZEE-3214
Type: bug

We still seem to support MySQL 5.7. Unfortunately default values for TEXT columns are not supported in that version.
Seems like Workflow Gateway sets it by default so it's rather required. Current schema seems to confirm that as well.

Hence the change.

@alongosz alongosz added the Bug label Jul 2, 2020
@alongosz alongosz requested review from Nattfarinn, webhdx and a team July 2, 2020 11:58
@alongosz alongosz changed the base branch from master to 3.0 July 2, 2020 11:58
@Omone
Copy link

Omone commented Jul 2, 2020

@alongosz
Copy link
Member Author

alongosz commented Jul 2, 2020

Hi, thanks for the update @alongosz
Actually neither Mysql8.0 version supports default values for TEXT and BLOB types

Hi @Omone.
In MySQL 8.0 the following would work:

ALTER TABLE ezeditorialworkflow_markings
    ADD COLUMN message TEXT NOT NULL default (''),

the difference is in braces, which introduce expression-ish thing.

Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified DB update from v2.5.12 to v3 with mysql 5.7, MariaDB and PostgreSQL, I haven't found any issues.

@lserwatka lserwatka merged commit 7e8f739 into 3.0 Jul 20, 2020
@lserwatka lserwatka deleted the base-3.0/ezee-3214-drop-wf-markings-message-col-default branch July 20, 2020 10:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

5 participants