Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-31780: Default doctrine dbal connection issue #152

Merged

Conversation

SerheyDolgushev
Copy link
Contributor

Wrong Doctrine DBAL storage connection is used when a new connection is appended in a 3rd party bundle.

More details at https://jira.ez.no/browse/EZP-31780.

@SerheyDolgushev SerheyDolgushev force-pushed the fix_doctrine_default_connection branch from 08665d4 to 965580c Compare July 31, 2020 12:32
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Issue might be solved as well by specifying explicitly connection in the repository configuration e.g.

ezplatform:
    repositories:
        default:
            storage:
                connection: default

@SerheyDolgushev
Copy link
Contributor Author

+1. Issue might be solved as well by specifying explicitly connection in the repository configuration e.g.

ezplatform:
    repositories:
        default:
            storage:
                connection: default

It was an initial fix here. But later we discovered that it is causing issues with custom ORM connections. So switched the fix to the current.

@andrerom
Copy link
Contributor

andrerom commented Aug 5, 2020

+1, but this should be applied to parent ezplatform repo as it can be generic problem or?

@mnocon mnocon self-assigned this Aug 10, 2020
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a custom Doctrine connection appended by another bundle - I was able to reproduce the issue on ezplatform-ee, but not on ezplatform (so PR there is not needed).

The fix solved the issue, the default connection was used in AdminUI instead of the new one.

@mnocon mnocon removed their assignment Aug 11, 2020
@adamwojs adamwojs merged commit 3ec220a into ezsystems:3.1 Aug 11, 2020
@adamwojs
Copy link
Member

Thank you for contribution @SerheyDolgushev!

# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

5 participants