Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZEE-3224: Added ezplatform-segmentation package #157

Merged
merged 2 commits into from
Oct 6, 2020
Merged

EZEE-3224: Added ezplatform-segmentation package #157

merged 2 commits into from
Oct 6, 2020

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Oct 6, 2020

@webhdx webhdx self-assigned this Oct 6, 2020
ViniTou
ViniTou approved these changes Oct 6, 2020
View reviewed changes
config/routes/ibexa_segmentation.yaml Outdated
@@ -0,0 +1,2 @@
ibexa.segmentation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ibexa.segmentation:
ibexa.ezplatform.segmentation:

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViniTou Are you sure ibexa.ezplatform and not ibexa.platform?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ibexa.platform

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it has been already done for DAM Connector: https://github.com/ezsystems/ezplatform-ee/blob/master/config/routes/ezplatform_connector_dam.yaml

I also think ibexa.platform.segmentation is more appropriate, along with ibexa_platform_segmentation.yaml filename. We should fix DAM connector alias and filename to follow this notation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 4a63b18

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my bad.
fix for DAM:
#158

@lserwatka lserwatka merged commit e9cd307 into master Oct 6, 2020
@lserwatka lserwatka deleted the segmentation branch October 6, 2020 10:54
@lserwatka
Copy link
Member

You can merge it sideways

@webhdx
Copy link
Contributor Author

webhdx commented Oct 6, 2020

@lserwatka Done.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@adamwojs adamwojs adamwojs approved these changes

@lserwatka lserwatka lserwatka approved these changes

Assignees

@webhdx webhdx

Labels
Feature Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@webhdx @lserwatka @adamwojs @Nattfarinn @ViniTou