Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix discrepancy between doc and twig template name #135

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Fix discrepancy between doc and twig template name #135

merged 1 commit into from
Oct 2, 2020

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented Oct 1, 2020

Question Answer
JIRA issue EZP-XXXXX
Type Bug
Target version 2.1+
BC breaks no, rather a BC fix depending on how you look at it
Doc needed no, doc is already correct if this is merged

Fixing name break in 3.0, as both doc, and the other methods have different syntax by now I suggest we simply close this in the following way, and cleanup when moving to new prefixes at some point in the future. IMO maybe with a bit better BC next time though.

Reported in: ibexa/documentation-developer#1132 (comment)

TODO:

  • Implement feature / fix a bug.
  • Implement tests + specs and passing ($ composer test)
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@andrerom
Fix discrepancy between doc and twig template name
96c80d7 
Fixing name break in 3.0, as both doc, and the other methods have different syntax by now I suggest we simply close this in the following way and cleanup when moving to new prefixes at some point in the future. Maybe with a bit better BC thinking next time though.

Reported in: ibexa/documentation-developer#1132 (comment)
@andrerom andrerom mentioned this pull request Oct 1, 2020
Merged
@lserwatka lserwatka merged commit 81dab5a into 2.1 Oct 2, 2020
@lserwatka lserwatka deleted the 3.x_twig_tag_location_naming branch October 2, 2020 07:34
@vidarl
Copy link
Member

vidarl commented Oct 2, 2020

ah.. shoot. I was 1 min too late..
I would suggest we call all functions ez_http_cache, but that we also keep the ez_http function names but mark them deprecated...

@ViniTou
Copy link
Contributor

ViniTou commented Nov 2, 2020 •
edited
Loading

I have merged it up together with #137
@lserwatka @andrerom

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz Awaiting requested review from alongosz

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrerom @vidarl @ViniTou @adamwojs @lserwatka