-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
EZP-29194: Improve repo prefix handling for purgeAll() and user context hash tagging #73
Conversation
Optional argument given from repo prefixer, take advantage in VarnishPurgeClient. (and next step will be to take advantage in Fastly too).
bdf5117
to
9911384
Compare
Seems this is unrelated |
@vidarl Passing and ready for your review (behat failure is unrelated to PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I have a few comments
So, prefix on default install will be "default_" ?
One worry I have with this prefix idea is that key size will increase and varnish and fastly have a limitation on header sizes
afaik default have a empty prefix But yes, even when this is not set we have had cases where customers have reached the limit on Varnish. So @kmadejski added doc on how to extend the limit as it's configurable. Last followup on that here: https://github.com/ezsystems/developer-documentation/pull/491/files Limit for Fastly seems to be 16Kb: So seems to be twice the default 8Kb limit of Varnish, but as it's not configurable that might be an issue in extreme cases. We have talked about maybe cutting down on the tag sizes and phase out the current tags in favour of shorter variants. Afaik that is the only thing we can do, besides documenting that people should use short repo names (we can also log warnings about that here btw). |
Issue: https://jira.ez.no/browse/EZP-29194
Followup to fix the following edge cases:
ez-all
, as this is used inpurgeAll()
on Varnish and Fastly. Makes surepurgeAll()
works the same in all Proxies; clearing all cache across all repositories.purge(['ez-all'])
) or from command line using fos command to clear byez-all
tag, these calls will/should be prefixed.Follow up on this is to add a optional cache clearer for symfony that takes advantage of the fixes in purgeAll() to call that when user is calling
bin/console cache:clear