EZP-30170: [VCL] Add own VCL for 2.5LTS to bump Varnish support there #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
approved these changes
Feb 25, 2019
andrerom
changed the title
|
@mnocon At this point it would have been great if meta used VCL from here, so there where cross testing ;) |
mnocon
requested changes
Feb 27, 2019
| // | ||
| // Make sure to at least adjust default parameters.yml, defaults there reflect our testing needs with docker. | ||
|
|
||
| vcl 5.1; |
There was a problem hiding this comment.
This value is not valid, according to docs it can be either 4.0 or 4.1: https://varnish-cache.org/docs/6.1/whats-new/upgrading-6.0.html#vcl-4-0-and-4-1
Varnish fails to starts with this VCL.
There was a problem hiding this comment.
Fixed in a335b3d
I set it to 4.1 which seems more future proof, if you see any issues with that shout out :)
andrerom
force-pushed
the
drop_varnish4_from_2.5
branch
from
a335b3d to
ab990e7
Compare
|
Merging for now, to unblock meta PR. @mnocon As discussed, could we have a follow up during certification so script in meta does install before building containers please so we can cover vcl and sorl config changes on travis behat runs in the future? /cc @lserwatka |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://jira.ez.no/browse/EZP-30170
Needed for ezsystems/ezplatform#349