-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
EZP-29886: Added loadObjectStateGroupByIdentifier/loadObjectStateByIdentifier methods to ObjectStateService #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entifier methods to ObjectStateService Co-authored-by: Douglas Hammond <wizhippo@gmail.com>
webhdx
approved these changes
Aug 19, 2020
mikadamczyk
approved these changes
Aug 19, 2020
ViniTou
approved these changes
Aug 19, 2020
PR updated according to @mikadamczyk code review suggestions. |
mnocon
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared the results from loadObjectStateGroupByIdentifier
with loadObjectStateGroup
and loadObjectStateByIdentifier
with loadObjectState
, looks good!
ViniTou
pushed a commit
that referenced
this pull request
Nov 4, 2020
…entifier methods to ObjectStateService (#100) Co-authored-by: Douglas Hammond <wizhippo@gmail.com>
Steveb-p
pushed a commit
that referenced
this pull request
May 31, 2022
Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.0
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.x
Introduced
loadObjectStateGroupByIdentifier(string $objectStateGroupIdentifier, array $prioritizedLanguages = []): ObjectStateGroup
loadObjectStateByIdentifier(ObjectStateGroup $objectStateGroup, string $objectStateIdentifier, array $prioritizedLanguages = []): ObjectState
methods to
\eZ\Publish\API\Repository\ObjectStateService
.PR is based on original @wizhippo work in ezsystems/ezpublish-kernel#2500. In compare to original PR code has been adapted to changes introduced in 3.0.
Needed to unblock implementation of Object State aggregation in https://github.com/ezsystems/ezplatform-elastic-search-engine/pull/13 ezsystems/ezplatform-solr-search-engine#192
Checklist:
$ composer fix-cs
).