Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-29886: Added loadObjectStateGroupByIdentifier/loadObjectStateByIdentifier methods to ObjectStateService #100

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

adamwojs
Copy link
Member

Question Answer
JIRA issue EZP-29886
Type feature
Target eZ Platform version v3.x
BC breaks no
Tests pass yes
Doc needed yes

Introduced

  • loadObjectStateGroupByIdentifier(string $objectStateGroupIdentifier, array $prioritizedLanguages = []): ObjectStateGroup
  • loadObjectStateByIdentifier(ObjectStateGroup $objectStateGroup, string $objectStateIdentifier, array $prioritizedLanguages = []): ObjectState

methods to \eZ\Publish\API\Repository\ObjectStateService.

PR is based on original @wizhippo work in ezsystems/ezpublish-kernel#2500. In compare to original PR code has been adapted to changes introduced in 3.0.

Needed to unblock implementation of Object State aggregation in https://github.com/ezsystems/ezplatform-elastic-search-engine/pull/13 ezsystems/ezplatform-solr-search-engine#192

Checklist:

  • PR description is updated.
  • Tests are implemented.
  • Added code follows Coding Standards (use $ composer fix-cs).
  • PR is ready for a review.

…entifier methods to ObjectStateService

Co-authored-by: Douglas Hammond <wizhippo@gmail.com>
@adamwojs adamwojs requested a review from a team August 19, 2020 12:40
@adamwojs adamwojs self-assigned this Aug 19, 2020
@adamwojs adamwojs added the Feature New feature or request label Aug 19, 2020
eZ/Publish/API/Repository/ObjectStateService.php Outdated Show resolved Hide resolved
eZ/Publish/API/Repository/ObjectStateService.php Outdated Show resolved Hide resolved
eZ/Publish/API/Repository/Tests/ObjectStateServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/API/Repository/Tests/ObjectStateServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/API/Repository/Tests/ObjectStateServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/API/Repository/Tests/ObjectStateServiceTest.php Outdated Show resolved Hide resolved
@adamwojs
Copy link
Member Author

PR updated according to @mikadamczyk code review suggestions.

Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared the results from loadObjectStateGroupByIdentifier with loadObjectStateGroup and loadObjectStateByIdentifier with loadObjectState, looks good!

@adamwojs adamwojs merged commit 950bd42 into master Aug 20, 2020
@adamwojs adamwojs deleted the ezp_29886 branch August 20, 2020 06:39
ViniTou pushed a commit that referenced this pull request Nov 4, 2020
…entifier methods to ObjectStateService (#100)

Co-authored-by: Douglas Hammond <wizhippo@gmail.com>
Steveb-p pushed a commit that referenced this pull request May 31, 2022
Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.0
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Feature New feature or request QA approved
Development

Successfully merging this pull request may close these issues.

5 participants