Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-31817: Enabled ezfloat values indexing #103

Merged
merged 3 commits into from
Sep 7, 2020
Merged

EZP-31817: Enabled ezfloat values indexing #103

merged 3 commits into from
Sep 7, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Aug 31, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-31817
Type improvement
Target eZ Platform version v3.x
BC breaks no
Tests pass yes
Doc needed no

Currently is not possible to search for ezfloat values (e.g. using \eZ\Publish\API\Repository\Values\Content\Query\Criterion\Field criterion).

Even if there is \eZ\Publish\SPI\FieldType\Indexable implementation registered for ezfloat FT (see \eZ\Publish\Core\FieldType\Float\SearchField) still \eZ\Publish\Core\FieldType\Float\Type::isSearchable returns false.

Checklist:

  • PR description is updated.
  • Tests are implemented.
  • Added code follows Coding Standards (use $ composer fix-cs).
  • PR is ready for a review.

@adamwojs adamwojs self-assigned this Aug 31, 2020
@adamwojs adamwojs mentioned this pull request Aug 31, 2020
Merged
15 tasks
@micszo micszo self-assigned this Sep 1, 2020
micszo
micszo approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE master with branch using PAPI and UI.

@micszo micszo removed their assignment Sep 7, 2020
@lserwatka lserwatka merged commit cb160c5 into master Sep 7, 2020
@lserwatka lserwatka deleted the searchable_float branch September 7, 2020 11:19
ViniTou pushed a commit that referenced this pull request Nov 4, 2020
@adamwojs @ViniTou
EZP-31817: Enabled ezfloat values indexing (#103)
1822cc4 
* EZP-31817: Enabled ezfloat values indexing

* fixup! EZP-31817: Enabled ezfloat values indexing

* fixup! EZP-31817: Enabled ezfloat values indexing
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

@kaff kaff kaff approved these changes

@lserwatka lserwatka lserwatka approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@adamwojs adamwojs

Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adamwojs @lserwatka @kaff @alongosz @micszo @ViniTou