Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-31544: changed $configResolver from private to protected and changed variable #39

Merged
merged 1 commit into from
Apr 8, 2020
Merged

EZP-31544: changed $configResolver from private to protected and changed variable #39

merged 1 commit into from
Apr 8, 2020

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
JIRA issue EZP-31544
Type bug
Target eZ Platform version v3.0
BC breaks no
Tests pass yes
Doc needed no

Corrected some variables after removed dynamic settings

Checklist:

  • PR description is updated.
  • Tests are implemented.
  • Added code follows Coding Standards (use $ composer fix-cs).
  • PR is ready for a review.

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Apr 7, 2020
adamwojs
adamwojs approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@tomaszszopinski tomaszszopinski self-assigned this Apr 8, 2020
tomaszszopinski
tomaszszopinski approved these changes Apr 8, 2020
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform EE 3.0 master with diff.

@lserwatka lserwatka merged commit f344942 into master Apr 8, 2020
@lserwatka lserwatka deleted the EZP-31544 branch April 8, 2020 13:37
Steveb-p pushed a commit that referenced this pull request May 31, 2022
@alongosz
Merged pull request #39 from ibexa/merge-bump-php-req
389a96a 
Merged-up:
* b411f65 [CI] Moved php-cs-fixer to another job
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@mateuszbieniek mateuszbieniek mateuszbieniek approved these changes

@konradoboza konradoboza konradoboza approved these changes

@adamwojs adamwojs adamwojs approved these changes

@lserwatka lserwatka lserwatka approved these changes

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@tomaszszopinski tomaszszopinski

Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mateuszdebinski @lserwatka @adamwojs @konradoboza @mateuszbieniek @tomaszszopinski