Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-31012: Fixed assertion for passwordUpdateAt value in UserServiceTest::testUpdateUserUpdatesExpectedProperties #45

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Apr 9, 2020

Question Answer
JIRA issue EZP-31012
Type bug
Target eZ Platform version 3.0.0
BC breaks no
Tests pass yes
Doc needed no

Fixed assertion for passwordUpdateAt value in eZ\Publish\API\Repository\Tests\UserServiceTest::testUpdateUserUpdatesExpectedProperties. The previous approach might lead to false-negative build results (because it was time sensitive).

Follow up for #30.

Checklist:

  • PR description is updated.
  • Tests are implemented.
  • Added code follows Coding Standards (use $ composer fix-cs).
  • PR is ready for a review.

…PI\Repository\Tests\UserServiceTest::testUpdateUserUpdatesExpectedProperties
@adamwojs adamwojs merged commit 43e0643 into master Apr 10, 2020
@adamwojs adamwojs deleted the fixed_password_updated_at_assertion branch April 10, 2020 07:09
Steveb-p pushed a commit that referenced this pull request May 31, 2022
Merge up of:
* ezsystems/ezpublish-kernel#3132 (the changes were needed only for 6.13 and were reverted in higher branches),
* #280.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants