Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-31591: Farsi (Persian) language is missing in internal locale conversion map #52

Merged
merged 2 commits into from
Apr 23, 2020
Merged

EZP-31591: Farsi (Persian) language is missing in internal locale conversion map #52

merged 2 commits into from
Apr 23, 2020

Conversation

kmadejski
Copy link
Member

Question Answer
JIRA issue EZP-31591
Type bug
Target eZ Platform version v3.0
BC breaks no
Tests pass yes
Doc needed no

This PR adds missing support for Farsi (Persian) language.

  • PR description is updated.
  • Added code follows Coding Standards (use $ composer fix-cs).
  • PR is ready for a review.

@kmadejski kmadejski self-assigned this Apr 21, 2020
@kmadejski kmadejski requested a review from adamwojs April 22, 2020 07:50
alongosz
alongosz requested changes Apr 22, 2020
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing languages are technically feature requests, not bugs. Given early life cycle of 3.0.1 I could accept that this time, but currently the history would show unrelated changes, more in the diff comment.

eZ/Publish/Core/MVC/Symfony/Locale/LocaleConverterInterface.php Show resolved Hide resolved
@lserwatka lserwatka merged commit 6a9df1d into 1.0 Apr 23, 2020
@lserwatka lserwatka deleted the ezp_31591 branch April 23, 2020 08:29
@lserwatka
Copy link
Member

You can merge it up.

@kmadejski
Copy link
Member Author

@lserwatka done in e09f22e.

Steveb-p pushed a commit that referenced this pull request May 31, 2022
@barw4
Merge IBX-1392: Implemented image filenames sanitization (#52)
f75c329
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs adamwojs approved these changes

@lserwatka lserwatka Awaiting requested review from lserwatka

Assignees

@kmadejski kmadejski

Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kmadejski @lserwatka @adamwojs @alongosz @ViniTou @bogusez