Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-31590: Added update feature for URL Wildcards #56

Merged
merged 1 commit into from
May 29, 2020
Merged

EZP-31590: Added update feature for URL Wildcards #56

merged 1 commit into from
May 29, 2020

Conversation

michal-myszka
Copy link
Contributor

@michal-myszka michal-myszka commented Apr 24, 2020 •
edited
Loading

Question Answer
JIRA issue https://jira.ez.no/browse/EZP-31590
Type feature
Target eZ Platform version v3.1
BC breaks no
Tests pass yes
Doc needed yes

Checklist:

  • PR description is updated.
  • Tests are implemented.
  • Added code follows Coding Standards (use $ composer fix-cs).
  • PR is ready for a review.

@michal-myszka michal-myszka self-assigned this Apr 24, 2020
@michal-myszka michal-myszka force-pushed the EZP-31590-url-management branch 3 times, most recently from 836bf55 to 6819fba Compare May 13, 2020 15:35
@michal-myszka michal-myszka marked this pull request as ready for review May 13, 2020 15:43
@michal-myszka michal-myszka changed the title WIP EZP-31590: Url management EZP-31590: Added update feature for URL Wildcards May 14, 2020
@michal-myszka michal-myszka requested a review from a team May 14, 2020 08:12
@michal-myszka michal-myszka requested a review from a team May 19, 2020 08:57
alongosz
alongosz requested changes May 19, 2020
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foremost I'm missing test coverage for wrong patterns (no patterns) in an update struct. I expect it to fail now, see the last diff comment.
Other remarks for tests are not that important.

eZ/Publish/API/Repository/Tests/URLWildcardServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/API/Repository/Tests/URLWildcardServiceTest.php Show resolved Hide resolved
eZ/Publish/API/Repository/URLWildcardService.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Event/Tests/URLWildcardServiceTest.php Show resolved Hide resolved
eZ/Publish/Core/Event/Tests/URLWildcardServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Event/Tests/URLWildcardServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Event/Tests/URLWildcardServiceTest.php Outdated Show resolved Hide resolved
eZ/Publish/SPI/Persistence/Content/UrlWildcard/Handler.php Outdated Show resolved Hide resolved
eZ/Publish/Core/Repository/URLWildcardService.php Show resolved Hide resolved
@michal-myszka michal-myszka removed the request for review from GrabowskiM May 19, 2020 11:27
EZP-31590 - Url management
f3ec33a 
Added url/view and url/update access validation for URLWildcards

Change parameters for update methods, fix-cs

Added URL Wildcards default setting

Fixes

Tests

Tests

Fix CS

Added events for update URL Wildcard

Changed name convention for variables $URLWildcard* -> $urlWildcard*

Fix cs

After CR changes
@michal-myszka michal-myszka force-pushed the EZP-31590-url-management branch from 7921784 to f3ec33a Compare May 27, 2020 08:38
@tomaszszopinski tomaszszopinski self-assigned this May 28, 2020
tomaszszopinski
tomaszszopinski approved these changes May 29, 2020
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 3.1 dev with diff.

@lserwatka lserwatka merged commit d7da49d into master May 29, 2020
@lserwatka lserwatka deleted the EZP-31590-url-management branch May 29, 2020 08:43
Steveb-p pushed a commit that referenced this pull request May 31, 2022
@Nattfarinn
IBX-1998: Rebranded routes in ibexa/core repository (#56)
abab257 
* IBX-1998: Rebranded routes in ibexa/core repository

* IBX-1998: Rebranded routes in ibexa/core repository

* IBX-1998: Rebranded routes in ibexa/core repository
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@alongosz alongosz alongosz approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@michal-myszka michal-myszka

@tomaszszopinski tomaszszopinski

Labels
QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michal-myszka @adamwojs @Nattfarinn @alongosz @tomaszszopinski @lserwatka