EZP-31595: Parametrized embedded Content's URL generation #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
reviewed
Jun 25, 2020
eZ/Publish/Core/MVC/Symfony/View/Builder/ContentViewBuilder.php
Outdated
Show resolved
Hide resolved
alongosz
requested changes
Jun 25, 2020
barw4
changed the title
adamwojs
reviewed
Jun 26, 2020
eZ/Bundle/EzPublishCoreBundle/Resources/views/default/content/embed.html.twig
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Wójs <adam.wojs@ez.no>
alongosz
approved these changes
Jun 26, 2020
webhdx
approved these changes
Jul 2, 2020
ViniTou
approved these changes
Jul 2, 2020
tomaszszopinski
approved these changes
Jul 9, 2020
|
You can merge it up. |
|
Merged: 14faac2 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a direct continuation of the following PR: #57
The additional parameter has been added to embed views that checks whether the generation of embed Contents' URLs is permitted - if not, the link will not be generated and will be replaced by Content's name.
Checklist:
$ composer fix-cs).