Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-31701: Marked ezpublish.spi.search_engine as lazy #82

Merged
merged 1 commit into from
Jun 24, 2020
Merged

EZP-31701: Marked ezpublish.spi.search_engine as lazy #82

merged 1 commit into from
Jun 24, 2020

Conversation

adamwojs
Copy link
Member

Question Answer
JIRA issue EZP-31701
Type bug
Target eZ Platform version 3.0
BC breaks no
Tests pass yes
Doc needed no

ez publish.api.search engine depends on repository configuration

ezplatform-kernel/eZ/Bundle/EzPublishCoreBundle/ApiLoader/SearchEngineFactory.php

Line 66 in b79252a

$repositoryConfig = $this->repositoryConfigurationProvider->getRepositoryConfig();

but service is instantiated before site access matching. As result it always created with configuration for default siteaccess.

More details (including steps to reproduce) in JIRA issue.

Checklist:

  • PR description is updated.
  • Tests are implemented.
  • Added code follows Coding Standards (use $ composer fix-cs).
  • PR is ready for a review.

@adamwojs adamwojs added the Bug Something isn't working label Jun 24, 2020
@adamwojs adamwojs requested a review from a team June 24, 2020 11:07
@adamwojs adamwojs self-assigned this Jun 24, 2020
@lserwatka lserwatka merged commit 2b2cb9d into 1.0 Jun 24, 2020
@lserwatka lserwatka deleted the ezp_31701 branch June 24, 2020 19:14
@lserwatka
Copy link
Member

@adamwojs you can merge it up.

@adamwojs
Copy link
Member Author

@lserwatka Done

@adriendupuis adriendupuis mentioned this pull request Jul 31, 2020
Closed
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@michal-myszka michal-myszka michal-myszka approved these changes

@mnocon mnocon mnocon approved these changes

@alongosz alongosz alongosz approved these changes

@lserwatka lserwatka lserwatka approved these changes

Assignees

@adamwojs adamwojs

Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamwojs @lserwatka @alongosz @mnocon @michal-myszka