Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

LegacyStorageFileRowReader: handle the case when statement->fetch returns false #89

Merged
merged 2 commits into from
Sep 29, 2020

Conversation

SerheyDolgushev
Copy link
Contributor

Question Answer
JIRA issue EZP-31748
Type bug
Target eZ Platform version v3.0.5, v3.1.0
BC breaks no
Tests pass yes
Doc needed no

In some cases ezplatform:io:migrate-files command fails because of the following error:

bin/console ezplatform:io:migrate-files --from=default,default --to=XXX,YYY --no-interaction -vvv

...

In LegacyStorageFileRowReader.php line 45:
 
 [ErrorException] 
 Notice: Trying to access array offset on value of type bool

Checklist:

  • PR description is updated.
  • Tests are implemented.
  • Added code follows Coding Standards (use $ composer fix-cs).
  • PR is ready for a review.

@mnocon mnocon requested a review from a team August 27, 2020 08:00
@kaff kaff requested a review from a team September 21, 2020 11:33
…/LegacyStorageFileRowReader.php

Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
@SerheyDolgushev
Copy link
Contributor Author

@alongosz committed your suggestion

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@lserwatka lserwatka merged commit f7bb25b into ezsystems:1.1 Sep 29, 2020
@lserwatka
Copy link
Member

@alongosz could you merge it up?

@alongosz
Copy link
Member

Merged up to master.

Thank you @SerheyDolgushev 🎉

Steveb-p pushed a commit that referenced this pull request May 31, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants