Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-31806: Casted destinationContentId to int #98

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Aug 18, 2020

Question Answer
JIRA issue EZP-31806
Type bug
Target eZ Platform version v3.x
BC breaks no
Tests pass yes
Doc needed no

As stated in \eZ\Publish\Core\FieldType\ImageAsset\Value

    /**
     * Related content id's.
     *
     * @var mixed|null
     */
    public $destinationContentId;

destination content ID could be also a string, as it is not utilized now and there is always int passed in terms of creating external connectors this needs to be unified in one way or another, till that it seems only fair to handle in both and cast that ID to int before passing to service.

Checklist:

  • PR description is updated.
  • Tests are implemented.
  • Added code follows Coding Standards (use $ composer fix-cs).
  • PR is ready for a review.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants