Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-31676: keep the offset defined in the query #40

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

bdunogier
Copy link
Member

@bdunogier bdunogier commented Jun 8, 2020

Question Answer
JIRA issue EZP-31676
Type improvement
Target eZ Platform version v2.5, v3.0, v3.1
BC breaks maybe...
Tests pass yes
Doc needed yes

Handles any predefined offset in the query (through parameters or through the query type itself).

The predefined offset is added to the one used for pagination, and removed from the total count.

@bdunogier bdunogier force-pushed the ezp31676-fixed_offset branch from e399952 to 84ad02b Compare June 8, 2020 10:51
@bdunogier bdunogier changed the base branch from master to 1.0 June 8, 2020 12:53
@bdunogier bdunogier force-pushed the ezp31676-fixed_offset branch from 84ad02b to 0535d0a Compare June 8, 2020 13:01
@bdunogier bdunogier marked this pull request as ready for review June 8, 2020 13:02
@bdunogier bdunogier requested review from adamwojs and Nattfarinn June 8, 2020 13:02
@lserwatka lserwatka merged commit 373a767 into 1.0 Jun 16, 2020
@lserwatka lserwatka deleted the ezp31676-fixed_offset branch June 16, 2020 06:52
@lserwatka
Copy link
Member

@adamwojs could you merge it up?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants