EZP-30835: Added support for Solr 7.7 #136

adamwojs · 2019-04-17T20:35:24Z

JIRA: https://jira.ez.no/browse/EZP-30835

Related SOLR issues

https://issues.apache.org/jira/browse/SOLR-11501:

Starting a query string with local-params {!myparser ...} is used to switch the
query parser to another, and is intended for use by Solr system developers, not end users doing searches. To reduce negative side-effects of unintended hack-ability, we've limited the cases that local-params will be parsed to only contexts in which the default parser is "lucene" or "func". So if defType=edismax then q={!myparser ...} won't work. In that example, put the desired query parser into defType. Another example is if deftype=edismax then hl.q={!myparser ...} won't work for the same reason. In that example, either put the desired query parser into hl.qparser or set hl.qparser=lucene. Most users won't run into these cases but some will and must change. If you must have full backwards compatibility, use luceneMatchVersion=7.1.0 or something earlier.

Ref. https://github.com/ezsystems/ezplatform-solr-search-engine/pull/136/files#diff-d75c9ba9fe393b04edf2db8762aa77b7L65

https://issues.apache.org/jira/browse/SOLR-10503:

CurrencyField has been deprecated in favor of new CurrencyFieldType

Dropped as is not used by eZ Platform

https://issues.apache.org/jira/browse/SOLR-10729:

Deprecated LatLonType, GeoHashField, SpatialPointVectorFieldType, and SpatialTermQueryPrefixTreeFieldType. Instead, switch to LatLonPointSpatialField or SpatialRecursivePrefixTreeFieldType or RptWithGeometrySpatialField.

Will be processed as a separate task: https://jira.ez.no/browse/EZP-30977

https://issues.apache.org/jira/browse/SOLR-?????:

Deprecated: All Trie* numeric and date field types have been deprecated in favor of *Point field types.

Replaced according to suggestion

https://issues.apache.org/jira/browse/SOLR-12770:

The 'shards' parameter handling logic changes to use a new config element to determine what hosts can be requested.

This is CI only related issue

https://issues.apache.org/jira/browse/SOLR-?????:

Index-time boosts have been removed from Lucene, and are no longer available from Solr. If any boosts are provided, they will be ignored by the indexing chain. As a replacement, index-time scoring factors should be indexed in a separate field and combined with the query score using a function query. See the section Function Queries for more information.

Ref. https://lucene.apache.org/solr/guide/7_2/major-changes-in-solr-7.html

Release

Due to the major changes in Solr, support for 7.X will be part of the ezplatform-solr-search-engine 2.0 release which will be compatible with eZ Platform 2.5 release. Solr 6.X will be dropped in this release.

Solr 7.X and Solr 8.X will be officialy supported in ezplatform-solr-search-engine 3.0 release which will be compatible with eZ Platform 3.X.

TODO

Add entries to the test matrix
Adjust bin/generate-solr-config.sh
Adjust schema.xml

andrerom · 2019-05-20T07:12:53Z

Will this also pass on Solr 6.6 or we drop support for that in 1.6?

adamwojs · 2019-05-28T08:16:41Z

Will this also pass on Solr 6.6 or we drop support for that in 1.6?

I will check 😉 IMHO we should drop Solr 6.6 support in release with Solr 7. Changelog for Solr/Lucene between 6.6 and 7.X is big (includes BC breaks) which might make hard to have the support of the same feature set for both versions.

andrerom · 2019-05-29T11:33:32Z

ok 👍

andrerom · 2019-08-01T13:20:55Z

bin/.travis/init_solr.sh

@@ -44,7 +44,7 @@ fi
 download() {
    case ${SOLR_VERSION} in
        # PS!!: Append versions and don't remove old once, kernel uses this script!
-        6.3.0|6.4.1|6.4.2|6.5.1|6.6.0|6.6.5 )
+        6.3.0|6.4.1|6.4.2|6.5.1|6.6.0|6.6.5|7.7.1 )


Nitpick: 7.7.2 is out
Also, any idea how much they have broken in 8 in terms of also testing this branch on Solr 8.2?

Nitpick: 7.7.2 is out

Thanks for the information! I will update PR.

Also, any idea how much they have broken in 8 in terms of also testing this branch on Solr 8.2?

Let's add 8.2 to the test matrix and we will see 😉

bin/.travis/init_solr.sh

andrerom · 2019-08-23T07:47:01Z

@adamwojs we kind of need this in 2.5 as well, people are expecting to be able to use 7.7LTS given 6.6 is starting to show its age.

Another issue is Debian 10 coming with Java 11, however don't seems like any Solr version supports it yet, so it's more likely to be added in upcoming Solr 8.x release.

adamwojs · 2019-09-26T14:25:28Z

@andrerom I discussed with @lserwatka Solr 7+ support in eZ Platform 2.5 and we decided to go as described in "Release" section in the PR description.

Updated branch-alias for dev-master in composer.json according to #136 > Due to the major changes in Solr, support for 7.X will be part of the ezplatform-solr-search-engine 2.0 release which will be compatible with eZ Platform 2.5 release. Solr 6.X will be dropped in this release. > Solr 7.X and Solr 8.X will be officialy supported in ezplatform-solr-search-engine 3.0 release which will be compatible with eZ Platform 3.X.

alongosz

In general I'd see README.md updated as well, to remember which version of Solr Bundle supports which Solr engine version.

alongosz · 2019-10-01T09:12:53Z

bin/.travis/init_solr.sh

@@ -44,7 +44,7 @@ fi
 download() {
    case ${SOLR_VERSION} in
        # PS!!: Append versions and don't remove old once, kernel uses this script!
-        6.3.0|6.4.1|6.4.2|6.5.1|6.6.0|6.6.5 )
+        6.3.0|6.4.1|6.4.2|6.5.1|6.6.0|6.6.5|7.7.2 )


If we decided to drop support for Solr 6.x in 2.0 of this bundle, we probably should remove them here as well, to avoid suggestion we still support it.

alongosz · 2019-10-01T09:15:52Z

bin/.travis/init_solr.sh


-    files+=("${config_dir}/currency.xml")
+    if [[ $SOLR_VERSION =~ ^(7) ]]; then


Do we need this check if we support 7.x only now?

alongosz · 2019-10-01T09:16:11Z

bin/.travis/init_solr.sh

-    files+=("${config_dir}/elevate.xml")
-    files+=("${config_dir}/solrconfig.xml")
+
+    if [[ ! $SOLR_VERSION =~ ^(7) ]]; then


same question here

alongosz · 2019-10-01T09:20:29Z

bin/generate-solr-config.sh

-cp ${SOLR_INSTALL_DIR}/server/solr/configsets/basic_configs/conf/{currency.xml,solrconfig.xml,stopwords.txt,synonyms.txt,elevate.xml} $DESTINATION_DIR
+
+if [[ $SOLR_VERSION =~ ^(7|8) ]]; then
+    cp ${SOLR_INSTALL_DIR}/server/solr/configsets/_default/conf/{solrconfig.xml,stopwords.txt,synonyms.txt} $DESTINATION_DIR


kmadejski

Besides previous comments it looks good to me, great job @adamwojs!

adamwojs · 2019-10-01T11:56:18Z

PR updated according to @alongosz code review suggestions.

alongosz · 2019-10-01T12:00:39Z

composer.json

@@ -12,7 +12,7 @@
    ],
    "require": {
        "php": "^7.1",
-        "ezsystems/ezpublish-kernel": "^7.5@dev",
+        "ezsystems/ezpublish-kernel": "dev-solr_77 as 7.5",


Friendly reminder ;)

m-tyrala · 2019-10-03T15:36:25Z

Everything's fine for me, QA approve.

adamwojs · 2019-10-04T07:15:56Z

PR has been rebased and squashed.

alongosz · 2019-10-04T07:36:19Z

Requires ezsystems/ezpublish-kernel#2775 for tests to pass, so merging now.

alongosz · 2019-10-04T07:36:54Z

@adamwojs could you merge up?

adamwojs · 2019-10-04T07:53:29Z

Done.

…and higher (ezsystems/ezplatform-solr-search-engine#136)

adamwojs changed the title ~~[Travis] Add coverage for Solr 7.7.1~~ [WIP][Travis] Add coverage for Solr 7.7.1 Apr 18, 2019

adamwojs self-assigned this Apr 18, 2019

adamwojs added the Feature label Apr 18, 2019

adamwojs force-pushed the solr_77 branch from f07ea54 to 0bb61bb Compare May 20, 2019 06:14

adamwojs force-pushed the solr_77 branch from 0bb61bb to 9b8d73c Compare August 1, 2019 11:30

andrerom reviewed Aug 1, 2019

View reviewed changes

adamwojs changed the title ~~[WIP][Travis] Add coverage for Solr 7.7.1~~ [WIP][Travis] Add coverage for Solr 7.7.2 Aug 1, 2019

andrerom reviewed Aug 21, 2019

View reviewed changes

bin/.travis/init_solr.sh Outdated Show resolved Hide resolved

adamwojs force-pushed the solr_77 branch from 4413ddb to dc7e881 Compare August 29, 2019 17:41

adamwojs changed the title ~~[WIP][Travis] Add coverage for Solr 7.7.2~~ [WIP][Travis] Add coverage for Solr 7.7 and 8.2 Aug 29, 2019

adamwojs changed the title ~~[WIP][Travis] Add coverage for Solr 7.7 and 8.2~~ [WIP] Support for Solr 7.7 and 8.2 Sep 22, 2019

adamwojs force-pushed the solr_77 branch 2 times, most recently from 29d12fb to d8c7400 Compare September 23, 2019 18:00

adamwojs changed the title ~~[WIP] Support for Solr 7.7 and 8.2~~ [WIP] EZP-30835: Support for Solr 7.7 and 8.2 Sep 25, 2019

adamwojs force-pushed the solr_77 branch 2 times, most recently from 5097963 to 31d145e Compare September 25, 2019 12:16

adamwojs changed the base branch from master to 2.0 September 26, 2019 11:12

adamwojs force-pushed the solr_77 branch 2 times, most recently from 0c43666 to ec9adee Compare September 26, 2019 11:15

adamwojs changed the title ~~[WIP] EZP-30835: Support for Solr 7.7 and 8.2~~ EZP-30835: Added support for Solr 7.7 Sep 26, 2019

adamwojs requested review from kmadejski, alongosz and ViniTou September 26, 2019 14:25

adamwojs mentioned this pull request Sep 30, 2019

EZP-30835: Added support for Solr 7.7 ezsystems/ezpublish-kernel#2775

Merged

4 tasks

This was referenced Sep 30, 2019

[composer] Set branch alias to 3.0.x-dev #152

Merged

[composer] Set branch alias to 2.0.x-dev #153

Merged

alongosz reviewed Oct 1, 2019

View reviewed changes

kmadejski approved these changes Oct 1, 2019

View reviewed changes

alongosz approved these changes Oct 1, 2019

View reviewed changes

alongosz reviewed Oct 1, 2019

View reviewed changes

alongosz added the Rebase required label Oct 1, 2019

m-tyrala added the QA Approved label Oct 3, 2019

m-tyrala approved these changes Oct 3, 2019

View reviewed changes

EZP-30835: Added support for Solr 7.7

f00e0c1

adamwojs force-pushed the solr_77 branch from 4506461 to f00e0c1 Compare October 4, 2019 07:15

alongosz merged commit da9056d into 2.0 Oct 4, 2019

alongosz deleted the solr_77 branch October 4, 2019 07:36

adamwojs removed the Rebase required label Oct 4, 2019

adamwojs mentioned this pull request Oct 4, 2019

Fixed duplicated random field type definition in schema.xml #156

Merged

adamwojs mentioned this pull request Jul 14, 2020

EC-190: Added support for SOLR 7.7 ezsystems/ezcommerce#21

Merged

mnocon mentioned this pull request Dec 28, 2021

IBX-1699: Bump defaults and requirements for Java, Solr, Elastic #226

Closed

3 tasks

hknezevic added a commit to netgen/ezplatform-search-extra that referenced this pull request Jan 27, 2023

Consolidate query parameters with vendor to add support for Solr 7.7 …

c136dec

…and higher (ezsystems/ezplatform-solr-search-engine#136)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EZP-30835: Added support for Solr 7.7 #136

EZP-30835: Added support for Solr 7.7 #136

adamwojs commented Apr 17, 2019 •

edited

Loading

andrerom commented May 20, 2019

adamwojs commented May 28, 2019

andrerom commented May 29, 2019 •

edited

Loading

andrerom Aug 1, 2019

adamwojs Aug 1, 2019

andrerom commented Aug 23, 2019 •

edited

Loading

adamwojs commented Sep 26, 2019 •

edited

Loading

alongosz left a comment

alongosz Oct 1, 2019

alongosz Oct 1, 2019

alongosz Oct 1, 2019

alongosz Oct 1, 2019

kmadejski left a comment

adamwojs commented Oct 1, 2019

alongosz Oct 1, 2019

m-tyrala commented Oct 3, 2019

adamwojs commented Oct 4, 2019

alongosz commented Oct 4, 2019

alongosz commented Oct 4, 2019

adamwojs commented Oct 4, 2019


		files+=("${config_dir}/currency.xml")
		if [[ $SOLR_VERSION =~ ^(7) ]]; then

EZP-30835: Added support for Solr 7.7 #136

EZP-30835: Added support for Solr 7.7 #136

Conversation

adamwojs commented Apr 17, 2019 • edited Loading

Related SOLR issues

Release

TODO

andrerom commented May 20, 2019

adamwojs commented May 28, 2019

andrerom commented May 29, 2019 • edited Loading

andrerom Aug 1, 2019

Choose a reason for hiding this comment

adamwojs Aug 1, 2019

Choose a reason for hiding this comment

andrerom commented Aug 23, 2019 • edited Loading

adamwojs commented Sep 26, 2019 • edited Loading

alongosz left a comment

Choose a reason for hiding this comment

alongosz Oct 1, 2019

Choose a reason for hiding this comment

alongosz Oct 1, 2019

Choose a reason for hiding this comment

alongosz Oct 1, 2019

Choose a reason for hiding this comment

alongosz Oct 1, 2019

Choose a reason for hiding this comment

kmadejski left a comment

Choose a reason for hiding this comment

adamwojs commented Oct 1, 2019

alongosz Oct 1, 2019

Choose a reason for hiding this comment

m-tyrala commented Oct 3, 2019

adamwojs commented Oct 4, 2019

alongosz commented Oct 4, 2019

alongosz commented Oct 4, 2019

adamwojs commented Oct 4, 2019

adamwojs commented Apr 17, 2019 •

edited

Loading

andrerom commented May 29, 2019 •

edited

Loading

andrerom commented Aug 23, 2019 •

edited

Loading

adamwojs commented Sep 26, 2019 •

edited

Loading