EZP-30951: Added missing support for searching (Not)Empty Field values #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszbieniek
requested review from
andrerom,
alongosz,
kmadejski and
konradoboza
2 tasks
mateuszbieniek
changed the title
mateuszbieniek
changed the title
|
@mateuszbieniek could you provide, either in this PR description or in the kernel one, a sample PHP code, so it's easier for both the Doc Team and the others to understand how they can use it? The scope is just a few lines, starting from building Criteria and ending with calling e.g. |
kmadejski
suggested changes
Oct 11, 2019
lib/FieldMapper/ContentTranslationFieldMapper/ContentDocumentNullFields.php
Outdated
Show resolved
Hide resolved
lib/FieldMapper/ContentTranslationFieldMapper/ContentDocumentNullFields.php
Outdated
Show resolved
Hide resolved
|
@alongosz sure thing! Ill do it on monday :) |
pspanja
reviewed
Oct 11, 2019
lib/FieldMapper/ContentTranslationFieldMapper/ContentDocumentEmptyFields.php
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mateuszbieniek
force-pushed
the
EZP-30951_1.6
branch
from
73bb0d9 to
39b80b9
Compare
mateuszbieniek
force-pushed
the
EZP-30951_1.6
branch
from
fbb3295 to
f7c78d2
Compare
konradoboza
approved these changes
Oct 17, 2019
adamwojs
requested changes
Oct 21, 2019
lib/FieldMapper/ContentTranslationFieldMapper/ContentDocumentEmptyFields.php
Show resolved
Hide resolved
adamwojs
approved these changes
Oct 21, 2019
mateuszbieniek
force-pushed
the
EZP-30951_1.6
branch
from
4129631 to
572a82a
Compare
kmadejski
approved these changes
Oct 21, 2019
mateuszbieniek
force-pushed
the
EZP-30951_1.6
branch
from
572a82a to
360c2a4
Compare
mateuszbieniek
force-pushed
the
EZP-30951_1.6
branch
from
360c2a4 to
50ba114
Compare
alongosz
reviewed
Oct 21, 2019
lib/FieldMapper/ContentTranslationFieldMapper/ContentDocumentEmptyFields.php
Outdated
Show resolved
Hide resolved
lib/FieldMapper/ContentTranslationFieldMapper/ContentDocumentEmptyFields.php
Outdated
Show resolved
Hide resolved
alongosz
requested changes
Oct 30, 2019
lib/FieldMapper/ContentTranslationFieldMapper/ContentDocumentEmptyFields.php
Outdated
Show resolved
Hide resolved
lib/FieldMapper/ContentTranslationFieldMapper/ContentDocumentEmptyFields.php
Outdated
Show resolved
Hide resolved
andrerom
approved these changes
Oct 30, 2019
lib/FieldMapper/ContentTranslationFieldMapper/ContentDocumentEmptyFields.php
Show resolved
Hide resolved
micszo
approved these changes
Nov 22, 2019
|
You can merge it up |
|
@lserwatka done. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.7for eZ Platformv2.5.xLTSThis PR adds Mapper, so a new index for not required fields will be added to Solr:
is_empty.is_empty(true/false) determines if Field is considered empty as per Feild Definition.The Developer then can search (not) empty Fields with
IsFieldEmptyCriterion.This PR requires these kernel changes: ezsystems/ezpublish-kernel#2821