Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-31113: Configured Slot for AssignSectionToSubtreeSignal #160

Merged
merged 1 commit into from
Feb 3, 2020
Merged

EZP-31113: Configured Slot for AssignSectionToSubtreeSignal #160

merged 1 commit into from
Feb 3, 2020

Conversation

kmadejski
Copy link
Member

This PR depends on: ezsystems/ezpublish-kernel#2862. Please refer to it for more information.

@kmadejski kmadejski self-assigned this Nov 7, 2019
andrerom
andrerom approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, but should cherry pick this one here as well: 436fedc

@andrerom
Copy link
Contributor

andrerom commented Nov 7, 2019

but should cherry pick this one here as well: 436fedc

ignore, this is not a hard dependency in this case 👍

@kmadejski
Copy link
Member Author

Tests are failing because depend on ezpublish-kernel PR.

@alongosz alongosz changed the title EZP-31113: AssignSectionToSubtreeSignal is not handled by search and HTTP cache EZP-31113: Configured Slot for AssignSectionToSubtreeSignal Nov 12, 2019
alongosz
alongosz approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please align commit message with the PR title I've just changed (sorry to bother you, if it's a single commit, it will be used instead when merging).

@kmadejski
Copy link
Member Author

@alongosz done in e6239a9.

@micszo micszo self-assigned this Nov 21, 2019
micszo
micszo approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.6 with diffs.

@micszo micszo removed their assignment Nov 25, 2019
@andrerom

This comment has been minimized.

# to view
@andrerom
Copy link
Contributor

andrerom commented Feb 3, 2020

Passing now, thanks @adamwojs!
Merging and stripping on merge to master.

@andrerom andrerom merged commit f3f62d6 into 1.7 Feb 3, 2020
@andrerom andrerom deleted the ezp_31113 branch February 3, 2020 10:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@micszo micszo micszo approved these changes

@alongosz alongosz alongosz approved these changes

@andrerom andrerom andrerom approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@kmadejski kmadejski

Labels
Bug QA Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kmadejski @andrerom @adamwojs @alongosz @micszo @ViniTou