Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-31422: Dropped deprecated and unused "ezplatform:solr_create_index" command. #171

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Feb 28, 2020

Question Answer
JIRA issue EZP-31422 blocking EZP-30921.
Bug/Improvement yes
New feature no
Target version master (3.0@dev) for eZ Platform v3.0
BC breaks yes
Tests pass yes
Doc needed yes

This PR drops the deprecated and unused "ezplatform:solr_create_index" Symfony command.

Doc

Please mention that it has been dropped, "ezplatform:reindex" should be used instead.

Side: it seems it's not even available in the Container, don't remmeber when this happened. But to be safe we should mention the above anyway.

QA

Please review if there's any left-over usage (esp. in Behat-related packages).
I think if Behat passes it can be merged as-is (nothing to test, since cmd wasn't really available in the Container).

TODO:

  • Wait for Travis

@alongosz alongosz changed the title Dropped deprecated and unused "ezplatform:solr_create_index" command. EZP-31422: Dropped deprecated and unused "ezplatform:solr_create_index" command. Feb 28, 2020
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK Behat does not use this command, looks good to me

@alongosz alongosz merged commit c57c2f0 into master Mar 2, 2020
@alongosz alongosz deleted the ezp-31422-drop-solr-create-index-cmd branch March 2, 2020 10:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

5 participants