EZP-31517: Refactored Indexer to rely on Doctrine\DBAL #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
4 tasks
alongosz
requested review from
adamwojs,
michal-myszka,
mikadamczyk,
Nattfarinn,
ViniTou and
webhdx
michal-myszka
approved these changes
Mar 25, 2020
|
FYI ping @ezsystems/documentation-team |
adamwojs
approved these changes
Mar 26, 2020
Nattfarinn
suggested changes
Mar 26, 2020
Nattfarinn
reviewed
Mar 26, 2020
Nattfarinn
approved these changes
Mar 26, 2020
tomaszszopinski
approved these changes
Mar 31, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.0Summary
This PR refactors Solr Search Indexer to rely on Doctrine Connection instead of Database Handler from Zeta Components (see ezsystems/ezplatform-kernel#10 for more details).
Additionally this Indexer code also relied on deprecated SPI
ContentInfo::$isPublishedproperty, which was fixed as well during refactoring.Doc
The service container parameter
ezpublish.spi.search.solr.indexer.classhas been dropped (no other BC promises here were broken).QA
ezplatform:reindexon Solr 7.7.2.Checklist:
Tests are implementedmissing test coverage, indexing itself covered on API.$ composer fix-cs).