Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-1090: Fixed calculations and displaying of ezdate FT, as it should always be represented in UTC #111

Closed
wants to merge 1 commit into from
Closed

IBX-1090: Fixed calculations and displaying of ezdate FT, as it should always be represented in UTC #111

wants to merge 1 commit into from

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Feb 9, 2022 •
edited
Loading

Question Answer
Tickets IBX-1090
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? yes/no
License GPL-2.0

ezsystems/ezplatform-kernel#285
ezsystems/ezplatform-admin-ui#2033

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

This was referenced Feb 9, 2022
Merged
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Steveb-p
Copy link
Contributor

Steveb-p commented Feb 9, 2022

I'm not sure this is the way to go. It works for ezdate, sure. But normal dates that refer to local time would be displayed incorrectly?

@ViniTou
Copy link
Contributor Author

ViniTou commented Feb 9, 2022

@Steveb-p
True, I think we kinda skipped that those filters could be used outside FieldTypes scope, WDYT @adamwojs ?

@ViniTou ViniTou requested review from a team and adamwojs February 9, 2022 13:29
@ViniTou ViniTou closed this Feb 10, 2022
@ViniTou ViniTou deleted the ibx-1090-added-default-values-for-twig-functions branch February 10, 2022 13:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViniTou @Steveb-p @alongosz