Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-30723:Mailing does not work on Platform.sh #429

Merged
merged 1 commit into from
Jul 4, 2019
Merged

EZP-30723:Mailing does not work on Platform.sh #429

merged 1 commit into from
Jul 4, 2019

Conversation

vidarl
Copy link
Member

@vidarl vidarl commented Jul 4, 2019

We don't set swiftmailer config correct on Platform.sh

IMPORTANT
When merging this to 2.4 and later, the following change is needed:

-if ($container->getParameter('mailer_host') === '127.0.0.1') {
+if ($container->resolveEnvPlaceholders($container->getParameter('mailer_host'), true) === '127.0.0.1') {

@vidarl vidarl requested a review from andrerom July 4, 2019 11:26
@vidarl vidarl requested a review from mnocon July 4, 2019 11:29
@vidarl vidarl changed the title [Platform.sh]Setting mailer_host EZP-30723:Mailing does not work on Platform.s Jul 4, 2019
@vidarl vidarl changed the title EZP-30723:Mailing does not work on Platform.s EZP-30723:Mailing does not work on Platform.sh Jul 4, 2019
@lserwatka lserwatka merged commit d1941bc into 1.13 Jul 4, 2019
@lserwatka lserwatka deleted the psh_mailer branch July 4, 2019 12:26
@lserwatka
Copy link
Member

You can merge it up.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mnocon mnocon mnocon approved these changes

@andrerom andrerom andrerom approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vidarl @lserwatka @andrerom @mnocon