-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Docker] Switched image format and added PostgreSQL service #590
Conversation
ce7ad95
to
615eada
Compare
@@ -13,8 +13,7 @@ services: | |||
nocopy: false | |||
|
|||
import-db: | |||
# Using dev for now, because we need mysql client | |||
image: ${PHP_IMAGE_DEV} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dev
image has been merged with the base image, so the mysql client is present in PHP_IMAGE
24279aa
to
6516991
Compare
@@ -10,8 +10,7 @@ DATABASE_PASSWORD=SetYourOwnPassword | |||
DATABASE_NAME=ezp | |||
|
|||
## Docker images (name and version) | |||
PHP_IMAGE=ezsystems/php:7.4-v1-node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still not sure if we should use 7.4 as default and not the lowest supported version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For defaults we should pick what we recommend, needs for test matrix to make sure we do pass on lowest and highest supported version should be set using ENVs in CI system IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it to use PHP7.3 by defult (recommended for Platform 2.5). Travis will run on PHP7.1 and 7.4 for testing.
Besides inline comments |
I think the reason for that was simply that I only tested docker stack on mariadb... But feel free to generalize it so it can be used with both, or rename it |
I've decided to keep db-stack as it is, as I haven't used Docker Stack yet and I'm not sure how to approach it (and renaming it to This PR in its current state allows us to run tests on PostgreSQL on Travis, which was my initial goal - IMHO we can work on adding more PostgreSQL support in the future if needed. |
1b35b5e
to
e673668
Compare
JIRA: https://jira.ez.no/browse/EZP-31620
This PR is the result of work done recently in docker-php, mostly ezsystems/docker-php#52.
I have:
ezsystems/php:7.4-v2-node10
and droppedPHP_IMAGE_DEV
, it's no longer used in our Docker stackENABLE_XDEBUG
andXDEBUG_CONFIG
variables to base-dev and base-prod (which should make Switched base-dev.yml docker-compose configuration for app container to -dev image #587 not needed anymore - xdebug is present in all images now)Passing PostgreSQL build: https://travis-ci.org/github/ezsystems/ezplatform/builds/715567661