Refactored session rest actions to their own controller (EZP-26329) #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
approved these changes
Sep 17, 2016
|
Hmm indeed. I did not get these errors locally... will check. |
bdunogier
force-pushed
the
ezp26329-rest_session_controller_refactoring
branch
3 times, most recently
from
5794017 to
e903165
Compare
glye
approved these changes
Sep 20, 2016
| - '@ezpublish_rest.session_authenticator' | ||
| - '%ezpublish_rest.csrf_token_intention%' | ||
| - '@?security.csrf.token_manager' | ||
| - '@?security.csrf.token_storage' |
There was a problem hiding this comment.
I thought we standardised on double quotes for these...? (Very minor issue, it's just nice to be consistent.)
There was a problem hiding this comment.
Did we ? Maybe...
Gotta admit that I actually prefer single quotes because:
- they don't require that you escape
\ - they're demanded by our coding standards for PHP (but not for YAML, I agree)
But it is indeed not consistent with what we've done so far.
There was a problem hiding this comment.
Follow-up: Standardise and make it consistent, one way or the other ;)
There was a problem hiding this comment.
Changed to single quotes, consistency > escaping :)
| use eZ\Publish\Core\REST\Common\Exceptions\NotFoundException; | ||
| use Symfony\Component\Security\Core\Exception\AccessDeniedException; | ||
| use Symfony\Component\Security\Core\Exception\AuthenticationException; | ||
| use Symfony\Component\Security\Csrf\TokenStorage\TokenStorageInterface; |
There was a problem hiding this comment.
Another minor nit: These are easier to read when sorted.
|
Did some extra cleanup, and applied @glye's comments. |
added 2 commits
September 23, 2016 08:43
delete, create and refresh session actions are deprecated in the User controller, and moved to a new one, SessionController.
bdunogier
force-pushed
the
ezp26329-rest_session_controller_refactoring
branch
from
6c6c1f9 to
f040223
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete, create and refresh session actions are deprecated in the User controller,
and moved to a new one, SessionController.
The REST functional tests now cover most of the session interactions, and passed without any issue. The code was moved as is from the updated one in the User controller, and Container calls changed to injected properties.