Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-30008: More unique uniqid() #2523

Merged
merged 2 commits into from
Jan 18, 2019
Merged

EZP-30008: More unique uniqid() #2523

merged 2 commits into from
Jan 18, 2019

Conversation

glye
Copy link
Member

@glye glye commented Jan 11, 2019 •
edited
Loading

Question Answer
JIRA issue EZP-30008
Bug/Improvement yes
New feature no
Target version 6.x/7.x
BC breaks no
Tests pass yes/no
Doc needed no

Use prefix and more_entropy wherever possible. Otherwise, silence warnings with @noinspection.
See also ezsystems/BehatBundle#72 and ezsystems/repository-forms#271

TODO:

  • Implement feature / fix a bug.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@glye glye requested review from alongosz and mikadamczyk January 14, 2019 08:14
@glye glye mentioned this pull request Jan 14, 2019
Merged
@glye glye mentioned this pull request Jan 14, 2019
Merged
@glye
Copy link
Member Author

glye commented Jan 17, 2019

Ping reviewers :)

@glye glye merged commit 776db6a into 6.7 Jan 18, 2019
@glye glye deleted the ezp30008_more_unique_uniqid branch January 18, 2019 12:46
@glye glye mentioned this pull request Jan 21, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glye @alongosz