Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-30136: Updating content with "ezuser" field will not commit changes to Solr #2544

Merged
merged 2 commits into from
Feb 22, 2019
Merged

EZP-30136: Updating content with "ezuser" field will not commit changes to Solr #2544

merged 2 commits into from
Feb 22, 2019

Conversation

mateuszbieniek
Copy link
Contributor

@mateuszbieniek mateuszbieniek commented Feb 15, 2019 •
edited by alongosz
Loading

Question Answer
JIRA issue EZP-30136
Bug/Improvement yes
New feature no
Tests pass yes, requires ezsystems/ezplatform-solr-search-engine#130
Target version 6.7, 6.13, 7.3, 7.4, master

Recreated this PR, as the last one got automatically closed after rebase.

This is part one of the fix for changes after updating content with ezuser field not being committed.
Part two ezsystems/ezplatform-solr-search-engine:
ezsystems/ezplatform-solr-search-engine#130

TODO

  • Remove TMP commit

@mateuszbieniek mateuszbieniek mentioned this pull request Feb 15, 2019
Merged
alongosz
alongosz requested changes Feb 15, 2019
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but what is missing is:

  • integration (API) test for UserService showing the issue,
  • maybe Elasticsearch handling, but TBD based on if the ^ test fails.

@mateuszbieniek mateuszbieniek force-pushed the EZP-30136 branch 4 times, most recently from 81018ac to d19726e Compare February 20, 2019 15:36
alongosz
alongosz approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing 🎉
Please don't forget to remove TMP commit. I've linked passing build in the PR description.

@alongosz alongosz changed the title EZP-30136 - Updating content with "ezuser" field will not commit changes to Solr EZP-30136: Updating content with "ezuser" field will not commit changes to Solr Feb 20, 2019
@micszo micszo self-assigned this Feb 21, 2019
micszo
micszo approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform v2.3.2 & v2.4.1 with both diffs using solr4 & solr6.

@micszo micszo removed their assignment Feb 22, 2019
@lserwatka lserwatka merged commit 3346119 into ezsystems:6.7 Feb 22, 2019
@lserwatka
Copy link
Member

Could you merge it up?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@micszo micszo micszo approved these changes

@kmadejski kmadejski kmadejski approved these changes

@alongosz alongosz alongosz approved these changes

@andrerom andrerom andrerom approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

Assignees
No one assigned
Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mateuszbieniek @lserwatka @andrerom @alongosz @kmadejski @micszo @konradoboza