EZP-30546: Several core services risks having wrong instance due to early config resolver use #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
alongosz
reviewed
May 20, 2019
eZ/Bundle/EzPublishCoreBundle/Command/CleanupVersionsCommand.php
Outdated
Show resolved
Hide resolved
alongosz
approved these changes
May 20, 2019
kmadejski
approved these changes
May 20, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.7This fixes warnings that will show up in EE 1.7 once #2636 is merged.
TL;DR; Commands are loaded to get their name long before siteaccess event is fired, so they have services with wrong SA settings injected.
Partly replaces #2634 with aim to have fix for all branches, and w/o having to rely on lazy commands unless needed (remaining cases will be commands directly or indirectly relying on config resolver in ctor/configure/init, @alongosz should be happy :) ).
TODO:
$ composer fix-cs).