EZP-30973: Made siteaccess aware repository to be used as default #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2019
adamwojs
force-pushed
the
ezp_30973
branch
2 times, most recently
from
d673237 to
89c1ce1
Compare
This was referenced Oct 17, 2019
Merged
adamwojs
force-pushed
the
ezp_30973
branch
2 times, most recently
from
2c6b88f to
caffcbb
Compare
mikadamczyk
approved these changes
Nov 4, 2019
alongosz
requested changes
Nov 12, 2019
| @@ -224,7 +224,7 @@ public function updateObjectStateGroup(APIObjectStateGroup $objectStateGroup, Ob | |||
| throw $e; | |||
| } | |||
|
|
|||
| return $this->buildDomainObjectStateGroupObject($spiObjectStateGroup); | |||
| return $this->buildDomainObjectStateGroupObject($spiObjectStateGroup, $objectStateGroup->prioritizedLanguages); | |||
There was a problem hiding this comment.
Please add @property-read string[] $prioritizedLanguages to \eZ\Publish\Core\Repository\Values\ObjectState\ObjectStateGroup
| @@ -380,7 +380,7 @@ public function updateObjectState(APIObjectState $objectState, ObjectStateUpdate | |||
| throw $e; | |||
| } | |||
|
|
|||
| return $this->buildDomainObjectStateObject($spiObjectState); | |||
| return $this->buildDomainObjectStateObject($spiObjectState, null, $objectState->prioritizedLanguages); | |||
There was a problem hiding this comment.
Please add @property-read string[] $prioritizedLanguages to \eZ\Publish\Core\Repository\Values\ObjectState\ObjectState
| @@ -1,19 +1,19 @@ | |||
| services: | |||
| # API Aliases | |||
| ezpublish.api.repository: | |||
| alias: eZ\Publish\Core\Event\Repository | |||
| alias: ezpublish.siteaccessaware.repository | |||
There was a problem hiding this comment.
using named services instead of FQCN is a step back IMHO
|
PR updated according to @alongosz code review suggestions. Additionally:
|
alongosz
approved these changes
Nov 13, 2019
ViniTou
approved these changes
Nov 14, 2019
2 tasks
micszo
approved these changes
Nov 29, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterTODO:
$ composer fix-cs).QA:
ezpublish.api.service.contentservice is injected