EZP-30760: Fixed broken link after historical parent location removed #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(inc. nop actions clear in ezplatform:urls:regenerate-aliases)
michal-myszka
changed the title
michal-myszka
force-pushed
the
EZP-30760-fix-broken-link-after-historical-parent-location-removed
branch
from
61485aa to
b1354b7
Compare
michal-myszka
requested review from
alongosz,
adamwojs,
mikadamczyk,
ViniTou,
konradoboza,
mateuszdebinski,
Nattfarinn and
webhdx
alongosz
requested changes
Mar 9, 2020
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Gateway.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Gateway.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Tests/Content/UrlAlias/UrlAliasHandlerTest.php
Show resolved
Hide resolved
...lish/Core/Persistence/Legacy/Tests/Content/UrlAlias/_fixtures/urlaliases_location_delete.php
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
alongosz
requested changes
Mar 12, 2020
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
added 3 commits
April 6, 2020 13:55
|
Just for info, this is described in https://jira.ez.no/browse/EZP-20773 and is related to another URL alias problem described in https://jira.ez.no/browse/EZP-20775. |
alongosz
requested changes
Apr 7, 2020
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
added 2 commits
April 8, 2020 09:07
alongosz
requested changes
Apr 9, 2020
eZ/Publish/Core/Persistence/Legacy/Content/UrlAlias/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
alongosz
approved these changes
Apr 9, 2020
konradoboza
approved these changes
Apr 10, 2020
mateuszdebinski
approved these changes
Apr 10, 2020
micszo
approved these changes
Apr 15, 2020
lserwatka
deleted the
EZP-30760-fix-broken-link-after-historical-parent-location-removed
branch
|
@alongosz could you merge it? |
|
Merged up and horizontally as ezsystems/ezplatform-kernel@6ae97c9 into |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5,masterThis PR resolves problem with broken links created by scenario described in https://jira.ez.no/browse/EZP-30760
and save the historical URL alias, even if historical location has been deleted (for example, alias /deleted-location/moved-somewhere-else-content will works fine)
There is included also nop-actions clearing for ezplatform:urls:regenerate-aliases (clear all unused nop-links (without parents))
TODO:
$ composer fix-cs).