Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

EZP-31136: Fixed removal of outdated links when publishing #3015

Merged
merged 1 commit into from
Apr 17, 2020
Merged

EZP-31136: Fixed removal of outdated links when publishing #3015

merged 1 commit into from
Apr 17, 2020

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented Apr 2, 2020 •
edited by alongosz
Loading

Question Answer
JIRA issue EZP-31136
Bug/Improvement yes
New feature no
Target version 7.5+
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mateuszdebinski mateuszdebinski changed the title [WIP]EZP-31136: Added unlink to remove old link from ezurl table EZP-31136: Added unlink to remove old link from ezurl table Apr 2, 2020
@ViniTou ViniTou self-requested a review April 9, 2020 09:38
ViniTou
ViniTou approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it is desired result that links that are used in old versions are no longer in link manager, because that will lead to it, right?

@gggeek
Copy link
Contributor

gggeek commented Apr 9, 2020

"As long as it is desired result that links that are used in old versions are no longer in link manager, because that will lead to it, right?"
I would say this seems the correct behaviour.
As long as re-publishing an old version does lead to that url appearing again, of course ;-)

@katarzynazawada katarzynazawada self-assigned this Apr 14, 2020
@alongosz alongosz merged commit 3072538 into 7.5 Apr 17, 2020
@alongosz alongosz deleted the EZP-31136 branch April 17, 2020 17:46
@alongosz alongosz changed the title EZP-31136: Added unlink to remove old link from ezurl table EZP-31136: Fixed removal of outdated links when publishing Apr 17, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@katarzynazawada katarzynazawada katarzynazawada approved these changes

@mateuszbieniek mateuszbieniek mateuszbieniek approved these changes

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

Assignees

@katarzynazawada katarzynazawada

Labels
Bug Ready for QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mateuszdebinski @gggeek @alongosz @ViniTou @konradoboza @mateuszbieniek @katarzynazawada