Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-31677: Added normalizer to decrese amount of data when compound matcher is encoded to JSON #3041

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Jun 4, 2020

Question Answer
JIRA issue EZP-31677
Bug yes
New feature no
Target version 6.13/
BC breaks no
Tests pass yes
Doc needed no

When the compound matcher has many sub matcher defined in his configuration than it results in serialized SiteAccess is much bigger in size than before. Previously serialized compound matcher has no serialized config and matchersMap properties. This PR removes them in CompoundMatcherNormalizer

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mikadamczyk mikadamczyk added the Bug label Jun 4, 2020
@mikadamczyk mikadamczyk self-assigned this Jun 4, 2020
@mikadamczyk mikadamczyk changed the title EZP-31677: Added normalizer to decrese amount of date when compound matcher is encoded to JSON EZP-31677: Added normalizer to decrese amount of data when compound matcher is encoded to JSON Jun 4, 2020
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
CS: please run up-to-date CS fixer check (ideally by merging up these changes into detached head of 7.5, since the rules are up to date there - wasn't possible to have eZ Platform Code Style on 6.13 due to Symfony version coupling).

Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 besides nitpicks mentioned by @alongosz

Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested on 1.13.5, 2.5.10 and 3.0. Problem does not occur anymore. Went through the list of machters and didn't find new issues.

@micszo micszo removed their assignment Jun 8, 2020
@lserwatka lserwatka merged commit c0efbbe into 6.13 Jun 8, 2020
@alongosz alongosz deleted the EZP-31677 branch June 10, 2020 15:21
blankse pushed a commit to datafactory/ezpublish-kernel that referenced this pull request Nov 10, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

6 participants