-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
EZP-31677: Added normalizer to decrese amount of data when compound matcher is encoded to JSON #3041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
CS: please run up-to-date CS fixer check (ideally by merging up these changes into detached head of 7.5, since the rules are up to date there - wasn't possible to have eZ Platform Code Style on 6.13 due to Symfony version coupling).
eZ/Publish/Core/MVC/Symfony/Component/Serializer/CompoundMatcherNormalizer.php
Show resolved
Hide resolved
eZ/Publish/Core/MVC/Symfony/Component/Serializer/CompoundMatcherNormalizer.php
Outdated
Show resolved
Hide resolved
eZ/Publish/Core/MVC/Symfony/Component/Serializer/CompoundMatcherNormalizer.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 besides nitpicks mentioned by @alongosz
…matcher is encoded to JSON
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested on 1.13.5, 2.5.10 and 3.0. Problem does not occur anymore. Went through the list of machters and didn't find new issues.
…matcher is encoded to JSON (ezsystems#3041) (cherry picked from commit c0efbbe)
6.13
/When the compound matcher has many sub matcher defined in his configuration than it results in serialized SiteAccess is much bigger in size than before. Previously serialized compound matcher has no serialized
config
andmatchersMap
properties. This PR removes them in CompoundMatcherNormalizerTODO:
$ composer fix-cs
).