Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

EZP-31768: Fixed cache invalidation during url alias reassignment #3062

Merged
merged 4 commits into from
Aug 28, 2020
Merged

EZP-31768: Fixed cache invalidation during url alias reassignment #3062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dead1b5
EZP-31768: Fixed cache invalidation during url alias relink
barw4 Aug 27, 2020
c63c7fa
EZP-31768: Add additional condition for tag invalidation
barw4 Aug 27, 2020
dd8975e
EZP-31768: Adapted related test
barw4 Aug 27, 2020
b2a7f0c
EZP-31768: CS
barw4 Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eZ/Publish/Core/Persistence/Cache/Tests/UrlAliasHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public function providerForUnCachedMethods(): array
// string $method, array $arguments, array? $tags, array? $key, mixed? $returnValue
return [
['publishUrlAliasForLocation', [44, 2, 'name', 'eng-GB', true, false], ['urlAlias-location-44', 'urlAlias-location-path-44', 'urlAlias-notFound']],
['createCustomUrlAlias', [44, '1/2/44', true, null, false], ['urlAlias-location-44', 'urlAlias-location-path-44', 'urlAlias-notFound']],
['createCustomUrlAlias', [44, '1/2/44', true, null, false], ['urlAlias-location-44', 'urlAlias-location-path-44', 'urlAlias-notFound', 'urlAlias-5'], null, new UrlAlias(['id' => 5])],
barw4 marked this conversation as resolved.
Show resolved Hide resolved
['createGlobalUrlAlias', ['something', '1/2/44', true, null, false], ['urlAlias-notFound']],
['createGlobalUrlAlias', ['something', '1/2/44', true, 'eng-GB', false], ['urlAlias-notFound']],
['listGlobalURLAliases', ['eng-GB', 10, 50]],
Expand Down
7 changes: 6 additions & 1 deletion eZ/Publish/Core/Persistence/Cache/UrlAliasHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,12 @@ public function createCustomUrlAlias($locationId, $path, $forwarding = false, $l
$alwaysAvailable
);

$this->cache->invalidateTags(['urlAlias-location-' . $locationId, 'urlAlias-location-path-' . $locationId, 'urlAlias-notFound']);
$this->cache->invalidateTags([
'urlAlias-location-' . $locationId,
'urlAlias-location-path-' . $locationId,
'urlAlias-notFound',
'urlAlias-' . $urlAlias->id,
]);

return $urlAlias;
}
Expand Down