New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

IBX-1237: Removed duplicated content tag #3123

Merged

adamwojs merged 1 commit into 7.5 from ibx-1237-duplicated-content-tag

Oct 12, 2021

Member

konradoboza commented Oct 12, 2021

Question	Answer
JIRA issue	IBX-1237
Type	bug
Target eZ Platform version	`v2.5`
BC breaks	no

The duplicated tag was wrongly introduced in https://github.com/ezsystems/ezpublish-kernel/pull/3114/files#diff-4e4afd929b7d374bdbb6ca18617eeb1482d209f7eb9493b20b6adafe112f1ea0R129.

Checklist:

Provided PR description.
Tested the solution manually.
Provided automated test coverage.
Checked that target branch is set correctly (master for features, the oldest supported for bugs).
Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
Asked for a review (ping @ezsystems/engineering-team).


          IBX-1237: Removed duplicated content tag

f3721be

konradoboza added Ready for review Bug labels

konradoboza requested review from adamwojs, Steveb-p and alongosz

October 12, 2021 09:04

konradoboza self-assigned this

adamwojs approved these changes

View reviewed changes

sonarqubecloud bot commented Oct 12, 2021

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Steveb-p approved these changes

View reviewed changes

Member Author

konradoboza commented Oct 12, 2021

Since this seems to be a defensive fix: do we involve QA?

Contributor

Steveb-p commented Oct 12, 2021

@konradoboza no need. The change is obvious and there is no chance of anything breaking.

It would be a waste of time.

konradoboza added Ready for MERGE and removed Ready for review labels

adamwojs merged commit baea4c5 into 7.5

adamwojs deleted the ibx-1237-duplicated-content-tag branch

October 12, 2021 09:24

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

Bug Ready for MERGE