EZP-29990: As an Administrator I want to translate ezselection Field Definition options #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This comment has been minimized.
This comment has been minimized.
alongosz
requested changes
Feb 20, 2019
webhdx
suggested changes
Feb 20, 2019
| if ($baseLanguage && $language) { | ||
| $names[$language->languageCode] = $fieldDef->getName($baseLanguage->languageCode); | ||
| $descriptions[$language->languageCode] = $fieldDef->getDescription($baseLanguage->languageCode); | ||
|
|
||
| if (isset($fieldDef->fieldSettings['multilingualOptions'][$baseLanguage->languageCode])) { |
There was a problem hiding this comment.
Since it's field specific it should be placed here. You could create an extension point here but I'm not sure if this should happen inside ContentTypeDraftMapper.
This comment has been minimized.
This comment has been minimized.
ViniTou
force-pushed
the
EZP-29990-translate-ezselection-options
branch
from
69dd3d1 to
50d6f64
Compare
alongosz
approved these changes
Feb 22, 2019
lib/Form/EventListener/SelectionMultilingualOptionsDataListener.php
Outdated
Show resolved
Hide resolved
tests/RepositoryForms/Data/Mapper/ContentTypeDraftMapperTest.php
Outdated
Show resolved
Hide resolved
…Field Definition options
…Definition options
ViniTou
force-pushed
the
EZP-29990-translate-ezselection-options
branch
from
058696f to
8cedc46
Compare
katarzynazawada
approved these changes
Feb 25, 2019
webhdx
approved these changes
Feb 25, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kernel:
ezsystems/ezpublish-kernel#2532
Admin-UI:
ezsystems/ezplatform-admin-ui#824
Checklist:
$ composer fix-cs)