EZP-30297: Error when I try to add a translation for a user object #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webhdx
suggested changes
Mar 15, 2019
There was a problem hiding this comment.
I will just write down my opinion I've already presented on Slack:
- We didn't want content translations to be a part of this package due to our intention to get rid of it in the future. This is why content translation feature was added to AdminUI.
- I'd put User Translations as a separate flow which uses
UserServicebecause editing Users viaContentServicedidn't work and we changed that. It might work in this case but it's not advised.
adamwojs
approved these changes
Mar 15, 2019
mikadamczyk
force-pushed
the
EZP-30297
branch
2 times, most recently
from
496bfd9 to
91a6a7b
Compare
barbaragr
approved these changes
Mar 15, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ezsystems/ezplatform-admin-ui#901
Checklist:
$ composer fix-cs)