EZP-31310: Fixed editing for content with multiple locations #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mikadamczyk
requested review from
adamwojs,
andrerom,
ViniTou,
devmysz and
webhdx
webhdx
approved these changes
Feb 14, 2020
ViniTou
approved these changes
Feb 14, 2020
devmysz
approved these changes
Feb 14, 2020
andrerom
reviewed
Feb 17, 2020
tomaszszopinski
approved these changes
Feb 18, 2020
mikadamczyk
force-pushed
the
EZP-31310
branch
from
f62fa9b to
ac943a5
Compare
|
Could you merge it up? |
Merged
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user wants to edit the content that has multiple locations and occurs checking if unpublished draft exists then we need to know in which location the user tries to do this. This is needed to prepare proper links to edit versions. We should do this when it is possible (when a user is on the location view). When the user wants to edit content from a dashboard then the location is unknown. Therefore ContentEditViewBuilder must not only check the main Location but also other possible locations to which a user may have access.
Checklist:
$ composer fix-cs)