Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Proper handling of image digests #230

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

smoehrle
Copy link

Images can be specified like:

nginx
nginx:1.27.0
nginx:1.27.0@sha256:67682bda769fae1ccf5183192b8daf37b64cae99c6c3302650f6f8bf5f0f95df
nginx@sha256:67682bda769fae1ccf5183192b8daf37b64cae99c6c3302650f6f8bf5f0f95df

At the moment ecs-deploy can only handle the second case. With this change, all 4 cases work properly.

@fabfuel
Copy link
Owner

fabfuel commented Jul 25, 2024

Hi @smoehrle

Thanks for the nice addition! Would you please add a test like this one which sets a tag with all of your newly supported image digests:

def test_task_set_tag(task_definition):
task_definition.set_images(u'foobar')
for container in task_definition.containers:
assert container[u'image'].endswith(u':foobar')

Thanks!
Fabian

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants