Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WIP: Nullable/Nullness support #4018

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WIP: Nullable/Nullness support #4018

wants to merge 2 commits into from

Conversation

MangelMaxime
Copy link
Member

I am starting this PR early to avoid duplicate work regarding nullable/nullness support #3887

@MangelMaxime MangelMaxime marked this pull request as draft January 22, 2025 13:00
@ncave
Copy link
Collaborator

ncave commented Jan 22, 2025

@MangelMaxime I would suggest doing separate PRs, for supporting nullable value type (i.e. System.Nullable<T>) and a different PR for nullable ref types (T | null), and keeping them as small as possible to be able to iterate on them.

Perhaps this PR can be renamed to Added support for FSharp.Linq.Nullable conversions.

@MangelMaxime
Copy link
Member Author

I would suggest doing separate PRs,

I agree this PR will need to be split because locally I have even more different fixes for others part of Fable because I am discovering some unsupported APIs.

I will make specialized PRs for the different changes.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants