Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix #3135 adding support for patchStatus and detection of patch type #3138

Merged
merged 1 commit into from
May 21, 2021

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented May 18, 2021

Description

Fix for #3135 - adding mock support for a json patch of status, and rejecting other patch types.

I could not find existing json merge or strategic merge logic in the existing dependencies. It looks like jakarta.json-api provides a json merge patch utility - but it seems easier for now to just return an unsupported status.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

Copy link
Member

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa requested a review from rohanKanojia May 20, 2021 13:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

90.5% 90.5% Coverage
0.0% 0.0% Duplication

@victornoel
Copy link

@shawkins @manusa any way to get those changes in 5.4.2 maybe? See #3267 :)

@manusa
Copy link
Member

manusa commented Jul 1, 2021

Hi @victornoel
5.5.0 has already been released and doesn't include significant breaking changes. Is there any specific reason why you would need this back-ported?

@victornoel
Copy link

@manusa actually, no reason no, I think we can safely ignore my earlier request, I will be using 5.5.0! Thx again :)

@manusa
Copy link
Member

manusa commented Jul 2, 2021

I will be using 5.5.0!

🚀 cool!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants