-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Exclude unexported fields from JSON schema #3191
Conversation
Can one of the admins verify this patch? |
Ignore fields contained in structs with JSON name "-" from the generated JSON schema.
a775d33
to
a0072a7
Compare
@oscerd / @rohanKanojia: Can we get this merged? |
I think it'll get merged soon. Let's wait for Marc's approval. |
@manusa: Could you take a look at this patch? Thanks in advance. |
Kudos, SonarCloud Quality Gate passed! |
@manusa / @rohanKanojia: Sorry to keep pinging, but I am waiting for this to merge to use internally for my project. Any chance we can get this merged ASAP? |
Hi, we are going to run the extensions generator to see if there's any direct impact on our currently generated classes. |
I checked and this change doesn't affect our current schema. It's safe to merge. I've created #3203 to add extension generators to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
Fixes #3190 by ignoring fields contained in structs with JSON name "-" from the generated JSON schema.
Type of change
test, version modification, documentation, etc.)
Checklist