Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for migration.k8s.io/v1alpha1 resources in OpenShiftClient #3224

Conversation

rohanKanojia
Copy link
Member

Description

  • Add new module openshift-model-storageversionmigrator/ for resources
    in OpenShift Kube Storage Version Migrator
  • Add DSL entrypoint openShiftClient.kubeStorageVersionMigrator() with
    which you can access the following resources:
    • StorageState : openShiftClient.kubeStorageVersionMigrator().storageStates()
    • StorageVersionMigration : openShiftClient.kubeStorageVersionMigrator().storageVersionMigrations()

Related to #2949

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

+ Add new module `openshift-model-storageversionmigrator/` for resources
  in OpenShift Kube Storage Version Migrator
+ Add DSL entrypoint `openShiftClient.kubeStorageVersionMigrator()` with
  which you can access the following resources:
  - StorageState : `openShiftClient.kubeStorageVersionMigrator().storageStates()`
  - StorageVersionMigration : `openShiftClient.kubeStorageVersionMigrator().storageVersionMigrations()`
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2021

@rohanKanojia rohanKanojia marked this pull request as ready for review June 8, 2021 06:30
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa added this to the 5.5.0 milestone Jun 9, 2021
@manusa manusa merged commit 20d87a8 into fabric8io:master Jun 9, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants