API missing fields

[jbrough]

Guys can you let me know an example response format you need from the API and I'll fix it up today.

You should be able to traverse the current response easily once you've derserialised the JSON into a JavaScript object but I'm happy to change it on the API side.

Also ant additional fields or info that needs adding, please provide a quick example and I'll add.

Thanks!

[HStewart23]

Hey @jbrough,

Here is the information we would ideally like in the API plus a few questions we have about it.

Data we would like to add :

• start/ end dates of trial (if end dates aren’t available some kind of indication of duration)
• primary contact (right now there are sometimes more that one)
• entry criteria
• trial phase
• disease stage
• description (if possible)
• side effects
• weblink to actual trial (if possible)

Data that would ideally be less nested :

• location/ locations of trial (already there)
• id (already there)
• gender (already there)
• max age/ min age (already there)
• recruiting (already there)
• conditions (already there)

Questions

• The ‘Locations’ part of the api often has multiple locations/ contacts why is this and which ones should we render?
• What are MESHTerms ?
• We noticed a field called note (inside Contact) with what appears to be a name in it. Is this the name of the person running the trial?

Thank you so much for helping us with this!

[jbrough]

sorry guys been off with a nasty cold, but means I'm free to work on this all day at least!

I'll update the api as I go, without changing existing fields, so you don't get broken.

Location - will filter to the nearest location, but for now just choose the first one.

Mesh terms - just keywords, ok to ignore.

Inside contact - yep this is contact person, but not necessary to display this info, I don't think.

I'll update this ticket as I push the chnages to the api.

[sesola]

Sorry about the cold Jamie. Get well soon

[HStewart23]

Hey @jbrough,
Hope you are feeling better ! How are things going with the API? Please, check out issue #63 as it has halted remote deployment for us and we'd really appreciate any help you can give towards solving it!
best,
Hannah

[jbrough]

Hey Hannah, I've fixed the https mixed-content issue by proxing via heroku, if you can update the api host to use https://curenetics-api.herokuapp.com it should be fine. https://curenetics-api.herokuapp.com/data/trials/uk/w1t/100/m/70/.json I think you're already supporting cross-origin / CORS Not pushed the API changes yet, the results look ok though as they are I think? Jamie

…

On Fri, Feb 15, 2019 at 4:32 PM Hannah ***@***.***> wrote: Hey @jbrough <https://github.com/jbrough>, Hope you are feeling better ! How are things going with the API? Please, check out issue #63 <#63> as it has halted remote deployment for us and we'd really appreciate any help you can give towards solving it! best, Hannah — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABIxEfX2CgVMfNIPo1-1mQ_t5X6sRnO2ks5vNuEqgaJpZM4a2K_w> .

[sesola]

Thanks Jamie Sola

…

On 18 Feb 2019, at 09:35, jbrough ***@***.***> wrote: Hey Hannah, I've fixed the https mixed-content issue by proxing via heroku, if you can update the api host to use https://curenetics-api.herokuapp.com it should be fine. https://curenetics-api.herokuapp.com/data/trials/uk/w1t/100/m/70/.json I think you're already supporting cross-origin / CORS Not pushed the API changes yet, the results look ok though as they are I think? Jamie On Fri, Feb 15, 2019 at 4:32 PM Hannah ***@***.***> wrote: > Hey @jbrough <https://github.com/jbrough>, > Hope you are feeling better ! How are things going with the API? Please, > check out issue #63 <#63> as > it has halted remote deployment for us and we'd really appreciate any help > you can give towards solving it! > best, > Hannah > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#38 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABIxEfX2CgVMfNIPo1-1mQ_t5X6sRnO2ks5vNuEqgaJpZM4a2K_w> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[HStewart23]

Thanks, @jbrough for sorting out the deploying issue! Would be great if you could push your changes to the API though as some of the results card info is currently hardcoded because it is not included in the API. The most important bits of information for us is the summary, trial phase and start/end date. 🌻