Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support PHP 8 in Ignition v1 #329

Merged
merged 15 commits into from
Oct 30, 2020
Merged

Support PHP 8 in Ignition v1 #329

merged 15 commits into from
Oct 30, 2020

Conversation

driesvints
Copy link
Contributor

We'll need v1 to support PHP 8 to allow the Laravel v6 skeleton to install.

@driesvints
Copy link
Contributor Author

I've pushed an extra commit to trigger builds on pull requests.

@driesvints driesvints marked this pull request as draft October 29, 2020 16:28
@driesvints driesvints marked this pull request as ready for review October 29, 2020 19:09
@driesvints
Copy link
Contributor Author

@freekmurze this one is ready now 🥳

@freekmurze freekmurze merged commit 1da1705 into facade:v1 Oct 30, 2020
@freekmurze
Copy link
Collaborator

Thanks!

@driesvints driesvints deleted the php8-v1 branch October 30, 2020 13:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants